Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Agent Classes & Parallel function calling for LLM Agent #965

Merged
merged 31 commits into from
Apr 29, 2024

Conversation

elisalimli
Copy link
Contributor

Summary

This PR refactors AgentBase, LangchainAgent, LLMAgent.

As well, I have added parallel function calling using native OpenAI function calling instead of relying Langchain implementation. Previously, parallel function calling was not working, because we were setting return_direct to True and we were always returning the first function call before even calling the second or so on.

Copy link

render bot commented Apr 18, 2024

@elisalimli elisalimli requested a review from homanp April 18, 2024 04:37
Copy link

vercel bot commented Apr 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
superagent-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 29, 2024 9:11am

Copy link
Collaborator

@homanp homanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be broken in the UI.

Screenshot 2024-04-18 at 13 13 48

Copy link
Collaborator

@homanp homanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use native function calling here for the specific model. The hybrid approach won't be necessary since most models support function calling.

Screenshot 2024-04-18 at 13 27 42

@elisalimli
Copy link
Contributor Author

Seems to be broken in the UI.

Screenshot 2024-04-18 at 13 13 48

I will create a new issue for it and solve. That was not caused but this PR, i have seen it before to.

@elisalimli elisalimli merged commit bb29b68 into main Apr 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants