Skip to content

Hashing-1#2256

Open
praxpk wants to merge 1 commit intosuper30admin:masterfrom
praxpk:master
Open

Hashing-1#2256
praxpk wants to merge 1 commit intosuper30admin:masterfrom
praxpk:master

Conversation

@praxpk
Copy link

@praxpk praxpk commented Jan 8, 2026

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The solutions are correct and handle edge cases well.
    • The code is clean, readable, and well-commented.
    • The use of dictionaries for bidirectional mapping in isIsomorphic and wordPattern is efficient and effective.
  • Areas for Improvement:
    • For groupAnagrams, consider using a hashing technique (like prime number multiplication) to avoid sorting and achieve better time complexity.
    • The comments could be more detailed to explain the rationale behind certain choices (e.g., why sorting is used for anagrams).
    • The variable names could be more descriptive (e.g., s_map and c_map could be pattern_to_word and word_to_pattern for clarity).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants