Skip to content

Completed Hashing-1#2255

Open
abhayb94 wants to merge 1 commit intosuper30admin:masterfrom
abhayb94:master
Open

Completed Hashing-1#2255
abhayb94 wants to merge 1 commit intosuper30admin:masterfrom
abhayb94:master

Conversation

@abhayb94
Copy link

@abhayb94 abhayb94 commented Jan 6, 2026

No description provided.

@super30admin
Copy link
Owner

  • Strengths:
    • The student demonstrates a strong understanding of hashing and its applications in solving these problems.
    • The code is well-commented and easy to follow.
    • The student provides multiple approaches for each problem, showing versatility in problem-solving.
  • Areas for Improvement:
    • In Approach 2 of Group Anagrams, the prime array includes an extra prime number (103) which is unnecessary since there are only 26 lowercase letters.
    • For Isomorphic Strings and Word Pattern, the student could consider using arrays instead of HashMaps for potentially better performance, given the fixed size of character sets.
    • The student could add more edge case checks, such as handling empty strings or null inputs explicitly in the comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants