Skip to content

Comments

Done Hashing-1#2253

Open
vaishnavi2231 wants to merge 1 commit intosuper30admin:masterfrom
vaishnavi2231:master
Open

Done Hashing-1#2253
vaishnavi2231 wants to merge 1 commit intosuper30admin:masterfrom
vaishnavi2231:master

Conversation

@vaishnavi2231
Copy link

No description provided.

@super30admin
Copy link
Owner

Strengths:

  • The student demonstrates a strong understanding of the problems and provides multiple solutions where applicable.
  • The code is clean, well-commented, and follows good practices.
  • The complexity analysis is accurate and thorough.

Areas for Improvement:

  • In the groupAnagrams solution, while the prime hashing approach is efficient, it's worth noting that for very long strings, the product of primes could become very large and potentially cause overflow issues in some languages (though Python handles big integers well).
  • The student could consider adding edge case handling comments (e.g., empty input) for completeness.
  • In the word_pattern solution, the variable names could be more descriptive (e.g., 'c' could be 'pattern_char').

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants