Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update exports from init file #928

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

silentworks
Copy link
Contributor

What kind of change does this PR introduce?

Bug fix to improve the use of the library.

What is the current behavior?

Async client and errors aren't being exported from the __init__.py file.

What is the new behavior?

Async client and errors are being exported from the __init__.py file.

Additional context

Add any other context or screenshots.

@silentworks silentworks requested a review from J0 September 20, 2024 09:47
from storage3.utils import StorageException
from supafunc.errors import FunctionsError, FunctionsHttpError, FunctionsRelayError
Copy link
Contributor

@J0 J0 Sep 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not urgent and definitely not in scope for this PR: I think there was an ask for a move from supafunc to supabase_functions can do that in the future

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes this has to wait until 3.0 of the library as it's a breaking change also this current addition is to help with migrating to that as user's will now import the errors from the supabase library rather than supafunc as some are probably doing now.

@silentworks silentworks merged commit 7a6199e into main Sep 20, 2024
8 checks passed
@silentworks silentworks deleted the silentworks/update-exports-from-init branch September 20, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants