fix: remove fetch from clientoptions #481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we re-run CI here? It's been a while and I'm not sure what this change breaks in the tests |
J0
approved these changes
Oct 2, 2023
|
Hm odd, should probably patch the tests but otherwise lgtm |
|
@anand2312 do you mind pushing an empty commit or similar? Can't figure out how to trigger a re-run since the branch is a little old. Seems like there's only the option to delete logs |
|
Done - looks like pre-commit was complaining about an unused import |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
fetchwas included in the ClientOptions because it must've been copied over from the JS client 😦