fix: allow overriding urls #399
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DavraYoung have you tested this? You check if option is null, but when unset, it looks like it will be undefined. hence, when none of these options are given, the urls will be set to undefined.. |
fdemir
reviewed
May 15, 2022
| this.realtimeUrl = `${_supabaseUrl}/realtime/v1`.replace('http', 'ws') | ||
| this.authUrl = `${_supabaseUrl}/auth/v1` | ||
| this.storageUrl = `${_supabaseUrl}/storage/v1` | ||
| this.restUrl = |
There was a problem hiding this comment.
it would be better if you use "logical or" operator here.
|
Closed as per #443 (comment). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR allows developers to control services urls, in case if they use Supabase behind the proxy.
What is the current behavior?
Current behavior appends /rest/v1, /realtime/v1, etc. paths to the url, which sometimes is not desired, and there is not option to easily disable this behavior.
What is the new behavior?
New behavior by default works as old one, but if user specifies overrideUrls option, he will be able to change "/*/v1" url append logic