feat: Add standard client headers #1130
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 14311896796Details
💛 - Coveralls |
grdsdev
changed the title
Vinzent03
reviewed
Mar 22, 2025
|
|
||
| class Constants { | ||
| static const Map<String, String> defaultHeaders = { | ||
| static String get platform { | ||
| return Platform.operatingSystem; |
There was a problem hiding this comment.
I know this is still draft, but still want to mention that this won't work on web.
You will either need a conditional import, or probably better use a constant to guard web with a definition like the kIsWeb in flutter:
const bool kIsWeb = bool.fromEnvironment('dart.library.js_util');There was a problem hiding this comment.
Thanks, @Vinzent03
Do we have any test for asserting that it doesn't break in Web? Didn't see any fail on CI.
There was a problem hiding this comment.
Sadly not yet, but hopefully #1140 solves this
…andard-client-headers-on-all
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.