fix: cheaper header validator#1178
Open
ferhatelmas wants to merge 1 commit into
Open
Conversation
This comment has been minimized.
This comment has been minimized.
Coverage Report for CI Build 28202916763Coverage decreased (-0.01%) to 78.805%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions18 previously-covered lines in 2 files lost coverage.
Coverage Stats💛 - Coveralls |
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
220b559 to
6b2b9ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactoring for perf
What is the current behavior?
Header length validation is allocating a buffer.
What is the new behavior?
Merge header validator plugin and s3 header validation.
Replace regex with a for loop of char code, which is faster for shorter strings.
This approach enables counting at the same time to prevent buffer allocation and do only one pass.
Additional context
Handle empty values in user metadata but block empty key.
Add aws prefix into header length check.