fix: fold timeout into scope query#1154
Open
ferhatelmas wants to merge 3 commits into
Open
Conversation
Coverage Report for CI Build 28108508086Coverage increased (+0.05%) to 78.573%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
fenos
reviewed
Jun 15, 2026
Contributor
|
It's an interesting approach, but it might beat us in case we never call Not sure if it's worth the performance gain here (1ms or less) vs a bit of a hidden timeout logic |
fenos
reviewed
Jun 15, 2026
Member
Author
that's fine and covered by a test |
cache serialization of headers/jwt payload per request Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
827b5b4 to
7e10952
Compare
Signed-off-by: ferhat elmas <elmas.ferhat@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Refactor for perf
What is the current behavior?
Right now, statement timeout is sent separately which introduces extra round trip.
What is the new behavior?
Delay until the first statement (set_config) and combine them together in the same query to reduce one round trip to db.
Additional context
Additionally, make query text for scope module level, and cache headers/jwt payload for multiple queries in the same connection.