Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: query parser: Add support for aggregate functions #521

Merged

Conversation

bnjmnt4n
Copy link
Contributor

@bnjmnt4n bnjmnt4n commented Mar 7, 2024

What kind of change does this PR introduce?

Feature.

What is the current behavior?

Aggregate functions, added in Postgrest v12, are not supported in the query parser.

What is the new behavior?

Aggregate functions are now supported in the query parser.

Additional context

Closes #520.

I also split out some of logic into separate helper types and added more docs to make it slightly more comprehensible.

Copy link
Member

@steve-chavez steve-chavez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

@steve-chavez steve-chavez merged commit 6f5d570 into supabase:master Mar 7, 2024
1 check passed
Copy link

🎉 This PR is included in version 1.14.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript Support for Aggregate Functions
2 participants