This repository was archived by the owner on Jan 23, 2026. It is now read-only.
Extend typing to make JSON expressions work with order#390
Closed
mqp wants to merge 1 commit intosupabase:masterfrom
Closed
Extend typing to make JSON expressions work with order#390mqp wants to merge 1 commit intosupabase:masterfrom
order#390mqp wants to merge 1 commit intosupabase:masterfrom
Conversation
Contributor
|
Hi @mqp ! Thanks for the contribution and your patience. This repository is deprecated and has moved to the new Supabase JS monorepo. Since this PR has been inactive for over a year, I’m going to close it to keep the old repo tidy, before archiving. If you believe this change is still needed, please open a new PR in the monorepo and include a link back to this thread for context:
Note: This old repository will be archived on October 10, 2025. Thank you again for your effort and understanding! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, if you wrote a query like this:
It would fail to typecheck, because the typing for
orderthought that if the first parameter isn't a column name from thefoostable in the schema, then it must be a foreign table reference, so theforeignTableproperty in the options must be specified.Now, Typescript can extract the column name from the
data->>countexpression, and check that against the schema.I think there are other expressions you can use here (the Postgrest docs mention computed columns) but this covers the JSON accessor case. (We could also probably use similar code in the filter builder to get better typechecking when using JSON accessors in a variety of methods.)