-
-
Notifications
You must be signed in to change notification settings - Fork 174
feat: advance to ubuntu 24.04 #1416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Changes from all commits
2622a30
61ce696
2105652
34fc1aa
197b513
8dfe998
6b07c45
07df582
f485a8c
30673f6
8c5a791
f6f2c6d
28739d0
267f283
a25cf18
9df2a03
849792f
3e95820
02ca971
0cec887
feedda1
ce3b45a
d331806
adedd8c
1a7c455
a4b3f81
721651d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,7 +66,7 @@ jobs: | |
|
||
- name: Upload pg_upgrade scripts to s3 staging | ||
run: | | ||
aws s3 cp /tmp/pg_upgrade_bin.tar.gz "s3://${{ secrets.ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz" | ||
aws s3 cp /tmp/pg_upgrade_bin.tar.gz s3://${{ secrets.ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/24.04.tar.gz | ||
|
||
- name: Slack Notification on Failure | ||
if: ${{ failure() }} | ||
|
@@ -113,7 +113,7 @@ jobs: | |
|
||
- name: Upload pg_upgrade scripts to s3 prod | ||
run: | | ||
aws s3 cp /tmp/pg_upgrade_bin.tar.gz "s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/20.04.tar.gz" | ||
aws s3 cp /tmp/pg_upgrade_bin.tar.gz s3://${{ secrets.PROD_ARTIFACTS_BUCKET }}/upgrades/postgres/supabase-postgres-${{ steps.process_release_version.outputs.version }}/24.04.tar.gz | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Ditto. Deduplication is needed. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yes, agree we should address this. As stated above, as @pcnc had discussed in slack thread, these are currently tied to infrastructure functionality. So, instead of trying to make those changes as a part of the upgrade to ubuntu 24.04 PR, let's create another PR where we can introduce those changes and test and make sure nothing else breaks. We should not try to accomplish that in this PR. |
||
|
||
- name: Slack Notification on Failure | ||
if: ${{ failure() }} | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,10 @@ | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal main restricted | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal-updates main restricted | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal universe | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal-updates universe | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal multiverse | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal-updates multiverse | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ focal-backports main restricted universe multiverse | ||
deb http://ports.ubuntu.com/ubuntu-ports focal-security main restricted | ||
deb http://ports.ubuntu.com/ubuntu-ports focal-security universe | ||
deb http://ports.ubuntu.com/ubuntu-ports focal-security multiverse | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble main restricted | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble-updates main restricted | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble universe | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble-updates universe | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble multiverse | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble-updates multiverse | ||
deb http://REGION.clouds.ports.ubuntu.com/ubuntu-ports/ noble-backports main restricted universe multiverse | ||
deb http://ports.ubuntu.com/ubuntu-ports noble-security main restricted | ||
deb http://ports.ubuntu.com/ubuntu-ports noble-security universe | ||
deb http://ports.ubuntu.com/ubuntu-ports noble-security multiverse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can these version changes be deduplicated?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steve-chavez we can certainly address this. But as @pcnc had discussed in slack thread, these are currently tied to infrastructure functionality. So, instead of trying to make those changes as a part of the upgrade to ubuntu 24.04 PR, let's create another PR where we can introduce those changes and test and make sure nothing else breaks. We should not try to accomplish that in this PR.