-
Notifications
You must be signed in to change notification settings - Fork 258
feat: add CSVQ support for rule parsing #3595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
80c020e
to
e266458
Compare
b9644ed
to
9f4a035
Compare
976759f
to
287e217
Compare
Pull Request Test Coverage Report for Build 15578639723Details
💛 - Coveralls |
0555e38
to
4bbfacf
Compare
added csvq driver and normalised column names across queries combine report queries to creats rollup for tables, indexes, roles and db overall
4bbfacf
to
a9f8459
Compare
@@ -45,10 +44,10 @@ func Run(ctx context.Context, config pgconn.Config, fsys afero.Fs, options ...fu | |||
return err | |||
} | |||
|
|||
table := "|Schema|Table|Last Vacuum|Last Auto Vacuum|Row count|Dead row count|Expect autovacuum?\n|-|-|-|-|-|-|-|\n" | |||
table := "|Name|Last Vacuum|Last Auto Vacuum|Row count|Dead row count|Expect autovacuum?\n|-|-|-|-|-|-|\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
table := "|Name|Last Vacuum|Last Auto Vacuum|Row count|Dead row count|Expect autovacuum?\n|-|-|-|-|-|-|\n" | |
table := "|Table|Last Vacuum|Last Auto Vacuum|Row count|Dead row count|Expect autovacuum?\n|-|-|-|-|-|-|\n" |
For clarity and consistency with unused_indexes.
(interval '1 millisecond' * ( | ||
COALESCE((row_to_json(s)->>'blk_read_time')::numeric, 0) + | ||
COALESCE((row_to_json(s)->>'blk_write_time')::numeric, 0) | ||
))::text AS sync_io_time, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are we converting to json then back to number?
sweatybridge
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Currently, inspect reports are quite modular and provide output where column titles can vary
What is the new behavior?
supabase/config.toml
Additional context
CSVQ has been added as a library to provide a table printout of some rules that are/are not met by the CSV files produced by
report