Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(config): diff email template content with remote #2873

Merged
merged 3 commits into from
Nov 13, 2024
Merged

fix(config): diff email template content with remote #2873

merged 3 commits into from
Nov 13, 2024

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Nov 12, 2024 •
edited
Loading

What kind of change does this PR introduce?

part 6 of #2814

What is the new behavior?

Loads email template from content_path to Content field for remote diff.

Additional context

Added assertSnapshotEqual test utility.

  • Run tests after rm -rf testdata/**/*.diff to initialise snapshot files
  • Run tests again to assert equality on subsequent changes

@coveralls
Copy link

coveralls commented Nov 12, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11812321756

Details

  • 1 of 2 (50.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 59.649%
Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/start/start.go 1 2 50.0%
Totals Coverage Status
Change from base Build 11810665148: 0.0%
Covered Lines: 6386
Relevant Lines: 10706
💛 - Coveralls

@sweatybridge sweatybridge changed the title feat(config): support defining template content in toml fix(config): diff email template content with remote Nov 13, 2024
@sweatybridge sweatybridge force-pushed the email-tmpl branch 2 times, most recently from f89656b to 4513954 Compare November 13, 2024 05:27
@sweatybridge sweatybridge enabled auto-merge (rebase) November 13, 2024 07:15
@sweatybridge sweatybridge merged commit b497d18 into develop Nov 13, 2024
9 checks passed
@sweatybridge sweatybridge deleted the email-tmpl branch November 13, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avallete avallete Awaiting requested review from avallete

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sweatybridge @coveralls