Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initial remote commit should include all schemas #1352

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Conversation

sweatybridge
Copy link
Contributor

@sweatybridge sweatybridge commented Aug 3, 2023

What kind of change does this PR introduce?

regression from #1310

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

@sweatybridge sweatybridge requested a review from a team as a code owner August 3, 2023 01:02
@sweatybridge sweatybridge changed the title fix: update migration table on remote commit fix: initial remote commit should include all schemas Aug 3, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 5745393499

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 57.296%

Changes Missing Coverage Covered Lines Changed/Added Lines %
internal/db/remote/commit/commit.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
internal/gen/keys/keys.go 5 12.31%
Totals Coverage Status
Change from base Build 5737862287: -0.04%
Covered Lines: 4743
Relevant Lines: 8278

💛 - Coveralls

@sweatybridge sweatybridge merged commit b52d90c into main Aug 3, 2023
18 checks passed
@sweatybridge sweatybridge deleted the fix-commit branch August 3, 2023 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants