feat(db): make statefulset serviceName and data subPath configurable - #242
Open
dhcsousa wants to merge 1 commit into
Open
feat(db): make statefulset serviceName and data subPath configurable#242dhcsousa wants to merge 1 commit into
dhcsousa wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature (opt-in, backward compatible).
What is the current behavior?
Closes #241. The
dbStatefulSet hardcodes two values:serviceName(alwayssupabase.db.fullname) and the data mount'ssubPath(alwayspostgres-data). Since a StatefulSet'sserviceNameis immutable, any existing install whose object carries a different (or empty) value failshelm upgradewith a "field is immutable" error, and volumes provisioned with data at a different location (e.g. the volume root) can't be mounted correctly.What is the new behavior?
Adds two optional values, both unset by default so the default render is unchanged:
deployment.db.serviceName: used verbatim when the key is present (including an explicit"", which some legacy StatefulSets need to reproduce in order to upgrade in place); falls back tosupabase.db.fullnamewhen absent.persistence.db.subPath: defaults topostgres-data; setting it to""mounts the volume root.Additional context
helm lintpasses and the defaulthelm templateoutput is byte-identical to main.