feat(chart): add configurable ServiceMonitor support - #214
Open
somaz94 wants to merge 1 commit into
Open
Conversation
somaz94
force-pushed
the
feat/chart-servicemonitor
branch
from
July 6, 2026 03:22
78f9939 to
0fa4f5e
Compare
somaz94
marked this pull request as ready for review
July 6, 2026 03:22
somaz94
force-pushed
the
feat/chart-servicemonitor
branch
from
July 13, 2026 02:39
0fa4f5e to
a134a74
Compare
somaz94
force-pushed
the
feat/chart-servicemonitor
branch
from
July 24, 2026 06:40
a134a74 to
4d8d768
Compare
Author
|
Hi @luizfelmach — could you approve the workflow runs for this PR? No checks have executed yet; they are queued awaiting first-time-contributor approval, so I have no way to show the change is green. The PR adds configurable ServiceMonitor support to the chart (opt-in, disabled by default) and bumps the chart version. Thanks! |
Contributor
|
Hi @somaz94. Thanks for that. I need some time to test this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds opt-in Prometheus Operator ServiceMonitor support to the supabase chart, addressing #137.
A top-level
serviceMonitorblock gates creation behind a master switch plus a per-component toggle. A ServiceMonitor is created only for a component that is both deployed (deployment.<component>.enabled) and enabled underserviceMonitor.components.<component>. Global defaults (interval, scrapeTimeout, port, path, scheme, tlsConfig, relabelings, metricRelabelings) can be overridden per component. Everything defaults to off, so the rendered output is unchanged unless a user opts in, and no Prometheus Operator CRD is required for the default install.To let each ServiceMonitor select a single component's Service, the recommended
app.kubernetes.io/componentlabel is added to every component Service. This is additive and does not change any existing selector.Chart version bumped 0.6.0 -> 0.7.0 (minor, new feature).
Validation (local):
helm lintandct lintpasshelm templatewith default values renders 0 ServiceMonitorhelm templatewithserviceMonitor.enabledplus per-component toggles renders one ServiceMonitor per enabled and deployed component, with per-component overrides appliedct installwas not run locally (it needs a kind cluster). Because the feature defaults to off, the installed resources are unchanged apart from the additive Service label.related: #137