feat(db): support referencing an existing migrations ConfigMap - #211
Open
fkhantsi wants to merge 1 commit into
Open
feat(db): support referencing an existing migrations ConfigMap#211fkhantsi wants to merge 1 commit into
fkhantsi wants to merge 1 commit into
Conversation
Add an optional `migrationConfigRef` value that points the db StatefulSet at an existing ConfigMap of migration scripts. When set, the chart no longer renders its own migrations ConfigMap, mirroring the `secret.*.secretRef` pattern used elsewhere in the chart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
migrationConfigRefvalue that points the db StatefulSet at an existing ConfigMap of migration scripts. When set, the chart no longer renders its own migrations ConfigMap, mirroring thesecret.*.secretRefpattern used elsewhere in the chart.What kind of change does this PR introduce?
feature
What is the current behavior?
A ConfigMap named
$(supabase.db.fullname)-migrationsis automatically created, and migration sql is mounted in it. The SQL must be inlined under theValues.yamlfile, and using an external.sqlfile is impossible.What is the new behavior?
Allows to externalize creation of the
ConfigMapstoring migrations. This permits users to either upload ConfigMap before the helm chart, or to use Kustomize'sconfigMapGeneratorto mount an actual .sql file instead of inlining sql data inside Values.The change is backwards compatible, and users can still inline migrations if they wish to.