feat: add opt-in preservation of secret values across helm upgrade - #199
Open
dhcsousa wants to merge 2 commits into
Open
feat: add opt-in preservation of secret values across helm upgrade#199dhcsousa wants to merge 2 commits into
dhcsousa wants to merge 2 commits into
Conversation
Contributor
|
See #198 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature (opt-in) + docs.
What is the current behavior?
Closes #198. Self-managed Secrets render from
.Values.secret.*(public demo defaults), so ahelm upgradethat doesn't re-supply overrides silently reverts live JWT/DB credentials to the demo values.What is the new behavior?
Adds opt-in
secret.preserveExisting(defaultfalse). When enabled, each self-managed secret reuses the existing in-cluster values vialookupand gets ahelm.sh/resource-policy: keepannotation. Applied to all self-managed secrets (jwt, db, dashboard, smtp, analytics, apikey, meta, minio, realtime, s3, bigquery);secretRefsecrets unaffected.Additional context
helm lintpasses; default render unchanged.