Make postgres initContainer images configurable via values.yaml - #116
Open
hongaar wants to merge 2 commits into
Open
Make postgres initContainer images configurable via values.yaml#116hongaar wants to merge 2 commits into
hongaar wants to merge 2 commits into
Conversation
Co-authored-by: hongaar <205834+hongaar@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
This PR makes postgres initContainer images configurable across Supabase services by introducing a global initContainer configuration section in values.yaml, replacing hardcoded postgres:15-alpine references.
- Adds global
initContainer.imageconfiguration with repository, pullPolicy, and tag settings - Updates all deployment templates to use the configurable image values instead of hardcoded strings
- Maintains backward compatibility with existing default values
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| charts/supabase/values.yaml | Adds global initContainer image configuration section |
| charts/supabase/templates/analytics/deployment.yaml | Updates initContainer to use configurable image values |
| charts/supabase/templates/auth/deployment.yaml | Updates initContainer to use configurable image values |
| charts/supabase/templates/realtime/deployment.yaml | Updates initContainer to use configurable image values |
| charts/supabase/templates/storage/deployment.yaml | Updates initContainer to use configurable image values |
| charts/supabase/templates/test/db.yaml | Updates test container to use configurable image values |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Author
|
Is this something that you're willing to implement? If yes, I will resolve merge conflicts in my branch. |
Contributor
|
Yes, absolutely. I appreciate it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the hardcoded
postgres:15-alpineimages used in initContainers across multiple Supabase services by making them configurable throughvalues.yaml.Problem
Previously, all initContainers across the Supabase Helm chart used a hardcoded
postgres:15-alpineimage, making it impossible to:Solution
Added a new global
initContainerconfiguration section tovalues.yamlthat follows the same pattern used by other services in the chart:Updated all deployment templates to reference this configurable value instead of the hardcoded image:
charts/supabase/templates/analytics/deployment.yamlcharts/supabase/templates/auth/deployment.yamlcharts/supabase/templates/realtime/deployment.yamlcharts/supabase/templates/storage/deployment.yamlcharts/supabase/templates/test/db.yamlUsage Example
Users can now customize the initContainer image in their
values.yaml:Backward Compatibility
The change is fully backward compatible - the default values maintain the existing behavior (
postgres:15-alpinewithIfNotPresentpull policy).Testing
🤖 This PR was generated by Copilot