Next.js auth integration package POC #3
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgoux
commented
Sep 18, 2024
utils/supabase/client.ts
Outdated
There was a problem hiding this comment.
This is only needed to add the generated types to the client and/or to pass special options to Supabase Client.
For the types I imagine we could leverage TypeScript module augmentation to set the Database type directly on the client exported by @supabase/auth/next/client. 🤔
jgoux
commented
Sep 19, 2024
| @@ -42,7 +42,7 @@ export function UserMenu({ user }: UserMenuProps) { | |||
| 'use server' | |||
| const supabase = createClient() | |||
| await supabase.auth.signOut() | |||
| redirect('/login') | |||
| redirect('/') | |||
There was a problem hiding this comment.
the middleware takes care of redirecting to the login page if the user is not authenticated. 👍
jgoux
commented
Sep 19, 2024
Comment on lines
-9
to
-11
| if (session) { | ||
| redirect('/') | ||
| } |
There was a problem hiding this comment.
it's better to centralize this logic of public vs protected pages in the middleware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR demonstrates what Supabase Auth integration would be like using https://www.npmjs.com/package/@supabase-labs/nextjs