removed relatives call to Wire.h and SPI.h #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 27, 2020
Open
Open
Not 100% sur of how dirty this fix is, but according to this (source)[https://forum.arduino.cc/index.php?topic=353602.0] I added the following in the `gpio_expander header` ``` #ifndef NOT_AN_INTERRUPT #define NOT_AN_INTERRUPT -1 #endif ```
Not 100% sur of how dirty this fix is, but according to this (source)[https://forum.arduino.cc/index.php?topic=353602.0] I added the following in the `gpio_expander header` ``` #ifndef NOT_AN_INTERRUPT #define NOT_AN_INTERRUPT -1 #endif ```
Added MAXSPISPEED test if not defined
Hard fix of
thijstriemstra
approved these changes
Aug 9, 2021
thijstriemstra
left a comment
thijstriemstra
left a comment
There was a problem hiding this comment.
ping @sumotoy can this be merged?
|
Hi @Ironicster / @sumotoy, do you think you could merge this PR? 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentionned in #7 issue
../SPI/SPI.h
and
../Wire/Wire.h
are now repalced by
SPI.h
and
Wire.h
#7