Add dmg-license dependency for macOS DMG creation #3
Conversation
Co-authored-by: sumitduster-iMac <[email protected]>
Co-authored-by: sumitduster-iMac <[email protected]>
|
@copilot Run npm run build
• electron-builder version=24.13.3 os=24.6.0 |
Co-authored-by: sumitduster-iMac <[email protected]>
Fixed in commit 1aa003c. The build was failing because the explicit icon path was causing an "unexpected EOF" error during icon conversion. I've removed the icon configuration - electron-builder will now handle icons automatically from the assets directory. The dmg-license dependency remains to fix the original DMG creation issue. |
There was a problem hiding this comment.
Pull request overview
This PR adds the missing dmg-license dependency required for electron-builder to successfully create DMG files on macOS. The dependency is correctly configured as optional since it's macOS-specific and should not break installations on other platforms.
Key Changes:
- Added
dmg-licensev1.0.11 to optionalDependencies in package.json - Updated package-lock.json with the new dependency and its transitive dependencies
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| package.json | Added dmg-license v1.0.11 to optionalDependencies section |
| package-lock.json | Added dmg-license dependency tree and updated dependency flags for packages that are now both dev and optional dependencies |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Create DMG for Lovable Mac App
Problem:
The repository had electron-builder configured to create DMG files, but the build was failing with the error: "Cannot find module 'dmg-license'".
Solution:
Added the missing
dmg-licensedependency required by electron-builder's dmg-builder component.Changes Made:
Technical Details:
dmg-license as optional dependency: This package is macOS-only (requires darwin OS), so it's marked as optional. It will be automatically installed during GitHub Actions builds on macOS runners but won't break installation on other platforms.
Icon handling: Removed explicit icon path configuration that was causing "unexpected EOF" error during icon conversion. Electron-builder will now handle icons automatically using the assets included in the files array.
Verification:
How to use:
The DMG can be built using existing npm scripts:
The GitHub Actions workflow will automatically build the DMG when code is pushed to main or when a version tag is created.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.
Note
Enables macOS DMG packaging by adding the missing
dmg-licensedependency and updating lockfile metadata.dmg-license@^1.0.11tooptionalDependenciesinpackage.json(macOS-only)package-lock.jsonto includedmg-licenseand mark several packages asdevOptionalelectron-builderconfig formacdmgx64remainsWritten by Cursor Bugbot for commit 1aa003c. Configure here.