-
-
Notifications
You must be signed in to change notification settings - Fork 0
Remove loading screen #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: sumitduster-iMac <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes the loading screen that displayed for 2 seconds before the webview rendered, allowing the application to render immediately on startup.
Key Changes:
- Removed 144 lines of loading screen CSS including animations (fadeInUp, pulse, shimmer, bounce)
- Removed loading screen HTML markup and associated JavaScript logic
- Eliminated the 2-second setTimeout delay before showing the main webview
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| styles.css | Removed all loading screen CSS classes (.loading-screen, .loading-content, .logo-container, etc.) and animation keyframes |
| index.html | Removed loading screen HTML div, removed JavaScript that controlled the fade-out animation and display toggle |
The code changes are clean and complete. All loading screen references have been successfully removed from the code files with no orphaned references remaining. The webview will now display immediately on application launch.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h1 class="loading-title">Lovable</h1> | ||
| <div class="loading-spinner"> | ||
| <div class="spinner-dot"></div> | ||
| <div class="spinner-dot"></div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will fail: loading-screen check breaks
Removing the loading-screen element from index.html will cause the CI pipeline to fail. The workflow at .github/workflows/ci.yml line 54 runs grep -q 'loading-screen' index.html || exit 1 to verify the loading screen exists. With the loading screen removed, this check will fail and block the PR from merging.
| background: linear-gradient(135deg, #0F172A 0%, #1E293B 100%); | ||
| } | ||
|
|
||
| /* Loading Screen */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI will fail: @Keyframes check breaks
Removing all @keyframes animation rules from styles.css will cause the CI pipeline to fail. The workflow at .github/workflows/ci.yml line 61 runs grep -q '@keyframes' styles.css || exit 1 to verify keyframe animations exist. With all keyframes removed, this check will fail and block the PR from merging.
Removes the 2-second loading screen that displayed before the webview loads.
Changes
The webview now renders immediately without intermediate UI.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.
Note
Removes the intermediate loading UI so the app shows the webview immediately.
loading-screenmarkup and relatedsetTimeoutfade logic fromindex.html; retainswebviewanddom-readylistenerstyles.css; keeps frame andwebviewstyling intactWritten by Cursor Bugbot for commit 520dadc. Configure here.