✨(sdk) create SDK #331
Merged
✨(sdk) create SDK #331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanVss
force-pushed
the
feat/sdk
branch
7 times, most recently
from
a0c12bd to
05b850f
Compare
NathanVss
force-pushed
the
feat/sdk
branch
5 times, most recently
from
9454ab1 to
93b6511
Compare
.github/workflows/meet.yml
Outdated
Comment on lines
178
to
211
| lint-sdk: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: cd src/sdk/library/ && npm ci | ||
|
|
||
| - name: Check linting | ||
| run: cd src/sdk/library/ && npm run lint | ||
|
|
||
| - name: Check format | ||
| run: cd src/sdk/library/ && npm run check | ||
|
|
||
| build-sdk: | ||
| runs-on: ubuntu-latest | ||
| needs: lint-sdk | ||
| steps: | ||
| - name: Checkout repository | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install dependencies | ||
| run: cd src/sdk/library/ && npm ci | ||
|
|
||
| - name: Build SDK | ||
| run: cd src/sdk/library/ && npm run build | ||
|
|
There was a problem hiding this comment.
to avoid repeating cd let's use a working-directory: src/sdk/library/ ?
These shortcuts improve DX and will be used in the next commits.
This variant is needed to implement the sdk create room button.
When displayed in an iframe, not being logged-in causes a redirection to the home page. Which is not what we want with the SDK integration. We just want to stay on the same page.
The create room button is a dedicated route. There is also a bit of logic implied in this commit, including the BroadcastChannel. The router has been updated with a /sdk negation in order to avoid including support and react query debug tool in the iframe.
It includes a consumer project which is simply a demo app. The sdk project includes the first version of the SDK, with a light React implementation. The first version lays down the foundations of the iframe sdk framework. The npm package logic is also already ready to be published.
Add basic jobs to handle the new sdk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Already logged-in
Not logged-in
Todo
Later goals