📝(readme) remove preprod account from readme #812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lunika
approved these changes
Mar 27, 2025
virgile-dev
force-pushed
the
remove-preprod-account
branch
from
4d73ab6 to
ed0020d
Compare
sampaccoud
reviewed
Mar 27, 2025
CHANGELOG.md
Outdated
| @@ -56,6 +56,7 @@ and this project adheres to | |||
|
|
|||
| - 🧑💻(frontend) change literal section open source #702 | |||
| - ♻️(frontend) replace cors proxy for export #695 | |||
| - 📝(readme) remove preprod account from readme #812 | |||
There was a problem hiding this comment.
I wouldn't list it in the changelog
There was a problem hiding this comment.
I think that if I don't it breaks the CI. Doesn't it @AntoLC ?
There was a problem hiding this comment.
No, changelog entry are not mandatory.
sampaccoud
reviewed
Mar 27, 2025
Having a preprod account using a yopmail account was a security bad practice Co-authored-by: Samuel Paccoud <[email protected]>
virgile-dev
force-pushed
the
remove-preprod-account
branch
from
40ea077 to
ec60087
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a preprod account using a yopmail account was a security bad practice