Accessibility #586
Draft
Accessibility #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pour le lecteur d'écran
To improve accessibility, certain parts of the code are modified with the help of a screen reader
sylvinus
reviewed
Jan 30, 2025
src/backend/core/tests/test_api_utils_ai_document_rate_throttles.py
Outdated
Show resolved
Hide resolved
…into accessibility
For good accessibility, the pinned icon will be read by the screen reader, but the simple icon will not
AntoLC
reviewed
Jan 31, 2025
| @@ -85,6 +94,7 @@ export const LeftPanelTargetFilters = () => { | |||
| <Icon | |||
| $variation={isActive ? '1000' : '700'} | |||
| iconName={query.icon} | |||
| aria-hidden="true" | |||
Comment on lines
32
to
35
| accessibility: { | ||
| 'aria-hidden': true, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I don't think this part is necessary, better to change directly inside the component.
Comment on lines
53
to
74
| aria-label={t('Back to home page')} | ||
| icon={ | ||
| <Icon $variation="800" $theme="primary" iconName="house" /> | ||
| <span aria-hidden="true"> | ||
| <Icon $variation="800" $theme="primary" iconName="house" /> | ||
| </span> | ||
| } | ||
| /> | ||
| {auth.authenticated && ( | ||
| <Button | ||
| onClick={searchModal.open} | ||
| size="medium" | ||
| color="tertiary-text" | ||
| aria-label={t('Search')} | ||
| icon={ | ||
| <Icon $variation="800" $theme="primary" iconName="search" /> | ||
| <span aria-hidden="true"> | ||
| <Icon | ||
| $variation="800" | ||
| $theme="primary" | ||
| iconName="search" | ||
| /> | ||
| </span> | ||
| } |
| @@ -69,7 +69,7 @@ export const Header = () => { | |||
| $height="fit-content" | |||
| $margin={{ top: 'auto' }} | |||
| > | |||
| <Image priority src={IconDocs} alt={t('Docs Logo')} width={25} /> | |||
| <Image priority src={IconDocs} alt="" width={25} /> | |||
There was a problem hiding this comment.
Why do you remove the alt part ?
| @@ -70,6 +69,7 @@ export const DocsGridActions = ({ | |||
| iconName="more_horiz" | |||
| $theme="primary" | |||
| $variation="600" | |||
| aria-hidden="true" | |||
| @@ -54,6 +54,7 @@ export const LanguagePicker = () => { | |||
| $theme="primary" | |||
| $weight="bold" | |||
| $variation="800" | |||
| aria-hidden="true" | |||
| @@ -125,7 +125,7 @@ export const Footer = () => { | |||
| `} | |||
| > | |||
| <Text | |||
| $variation="600" | |||
| $variation="700" | |||
There was a problem hiding this comment.
I don't think this pull request should aim to modify the design.
| @@ -1,3 +1,4 @@ | |||
| //import { t } from 'i18next'; | |||
-modifications after Sylvain's commentary -modifications after Anto's commentaries
je ne commite que les modifications annoncées dans le commit précédent
- Read the Tooltip with the number of participants, not the icon - In LeftPanel, when navigating with tab, we can see where we are
- In DocGrid, when navigating with tab, we can see where we are - In Doc, don't read "doc title input" but "rename" - In docSearch, don't read "search" icon and read "aucun document trouvé" with screen reader
…into accessibility
The elements focused with "Tab" are visible and consistent with the defined style.
The modal for document options has been modified to allow navigation using "tab" and to be closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
To improve accessibility, certain parts of the code will be modified.
For this, I use a screen reader for testing and validation.
Proposal
To do : https://docs.numerique.gouv.fr/docs/65993bb6-3e94-4a32-b848-9a1e019ab849/