⚡️(frontend) improve perf on upload and table of contents #1662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
added
bug
AntoLC
changed the title
AntoLC
changed the title
AntoLC
changed the title
AntoLC
force-pushed
the
enhance/hooks-editors
branch
from
8cb92fa to
e608769
Compare
AntoLC
changed the title
AntoLC
changed the title
AntoLC
force-pushed
the
enhance/hooks-editors
branch
2 times, most recently
from
9cea74d to
5598788
Compare
|
Size Change: +130 B (0%) Total Size: 4.11 MB
|
Ovgodd
approved these changes
Dec 1, 2025
Collaborator
Ovgodd
left a comment
Ovgodd
left a comment
There was a problem hiding this comment.
Nice ! just made a very small proposal ( non blocking )
| /* During collaboration, another user might have updated the block */ | ||
| } | ||
| // Add random delay to reduce collision probability during collaboration | ||
| const randomDelay = Math.random() * 800; |
src/frontend/apps/impress/src/features/docs/doc-editor/hook/useHeadings.tsx
Outdated
Show resolved
Hide resolved
| /** | ||
| * Replace the resource block by a uploadLoader block to show analyzing status | ||
| */ | ||
| const replaceBlockWithUploadLoader = useCallback( |
Collaborator
There was a problem hiding this comment.
Would it make sense to extract this into a utility function if we plan to reuse it later?
Collaborator
Author
There was a problem hiding this comment.
It is hypothetical, let's do that when the situation would happen.
- the Table of Contents stickiness now covers the full height of the viewport, before it was limited to 100vh - we listen the scroll to highlight the heading in the Table of Contents only when the Table of Contents is open - We debounce the editor change to avoid excessive updates to the Table of Contents
We notices that `context.getChanges` was very greedy, on a large document with multiple users collaborating, it caused performance issues. We change the way that we track a upload by listening onUploadEnd event instead of tracking all changes in the document. When a doc opens, we check if there are any ongoing uploads and resume them. We fix as well a race condition that could happen when multiple collaborators were on a document during an upload.
AntoLC
force-pushed
the
enhance/hooks-editors
branch
from
5598788 to
9aeedd1
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
During investigations about some users having theirs docs quite slow, we found a method that slow down a lot the users typing on a big documents.
docs/src/frontend/apps/impress/src/features/docs/doc-editor/hook/useUploadFile.tsx
Line 45 in 2864669
Proposal
100vh.