✨(frontend) improve mobile UX by showing subdocs count #1540
+130
−47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
force-pushed
the
feat/1314-show-sub-docs-count
branch
from
e79dba5 to
050189f
Compare
Ovgodd
commented
Oct 30, 2025
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsx
Outdated
Show resolved
Hide resolved
|
Size Change: +211 B (+0.01%) Total Size: 3.68 MB
|
AntoLC
reviewed
Nov 7, 2025
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsx
Outdated
Show resolved
Hide resolved
Comment on lines
31
to
46
| const { data: childrenPage } = useDocChildren( | ||
| { docId: doc.id, page_size: 1 }, | ||
| { enabled: true }, | ||
| ); | ||
| const countFromTreeContext = | ||
| treeContext?.root?.id === doc.id | ||
| ? treeContext?.treeData?.nodes?.length | ||
| : undefined; | ||
|
|
||
| const childrenCount = | ||
| countFromTreeContext ?? | ||
| childrenPage?.count ?? | ||
| doc.numchild ?? | ||
| tree?.children?.length ?? | ||
| 0; | ||
|
|
Collaborator
There was a problem hiding this comment.
Do we really need all that ? Why is doc.numchild not enough ?
Collaborator
Author
There was a problem hiding this comment.
Do we really need all that ? Why is
doc.numchildnot enough ?
@AntoLC I used TreeContext’s count because numchild displayed 0 on the root document, and hides the badge; with countFromTreeContext the root shows the correct visible child count,
wdyt ? I didn't find another way
and I remove useDocChildren here (it worked without it) and simplify childrenCount.
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsx
Show resolved
Hide resolved
src/frontend/apps/impress/src/features/docs/doc-header/components/DocHeaderInfo.tsx
Outdated
Show resolved
Hide resolved
Ovgodd
force-pushed
the
feat/1314-show-sub-docs-count
branch
from
050189f to
e6bbbf3
Compare
helps users notice root documents have children in mobile view Signed-off-by: Cyril <[email protected]>
ensures numchild count is displayed correctly on mobile interface Signed-off-by: Cyril <[email protected]>
Ovgodd
force-pushed
the
feat/1314-show-sub-docs-count
branch
from
0e17f4f to
45dba48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Improve mobile user experience by indicating when a document or a subdocument has children.
issue : 1314
Proposal