✨(frontend) subdocs can manage link reach #1190
Conversation
AntoLC
force-pushed
the
refacto/link-reach-subdocs
branch
from
6168b6c to
90c4a82
Compare
AntoLC
changed the title
AntoLC
force-pushed
the
refacto/link-reach-subdocs
branch
2 times, most recently
from
d39c772 to
c3ded8f
Compare
AntoLC
force-pushed
the
refacto/link-reach-subdocs
branch
from
c3ded8f to
97248eb
Compare
| isCurrentParent: treeContext?.root?.id === doc.id || doc.depth === 1, // it can be a child but not for the current user | ||
| isTopParent: doc.depth === 1, | ||
| isChild: doc.depth > 1, | ||
| isCurrentTopParent: typeof doc.children === 'undefined', // it can be a child but not for the current user |
There was a problem hiding this comment.
if a doc has no children, it can't be a parent. Not sure to understand what you are looking for.
There was a problem hiding this comment.
I need to know if a doc is the current root, the problem is, a child can be a root for another user, so doc.depth === 1 cannot work in some cases:
Parent -> restricted
├─Child -> Public
If I share the Child link to a anonymous user, Child will be a root for this anonymous user, with doc.depth === 2.
The only variable available to know if a doc is the current tree root, is with the property children apparently.
If you can make me a clean backend property it will be nice though (ex: doc.is_root).
There was a problem hiding this comment.
The doc response came from the endpoint documents/[DOC_ID]/, it is why it was without child array.
There is not a reliable way to know if a doc is the top root without context, I use another way to get the information that I need so:
AntoLC
force-pushed
the
refacto/link-reach-subdocs
branch
from
97248eb to
c55c4fa
Compare
The subdocs can now have their own link reach properties, dissociated from the parent document.
Using the treeContext was causing issues with the current parent detection, in many places the context is not available. "depth" property is more reliable than "nb_accesses_ancestors".
AntoLC
force-pushed
the
refacto/link-reach-subdocs
branch
from
c55c4fa to
e8147d0
Compare
Purpose
The subdocs can now have their own link reach properties, dissociated from the parent document.
Proposal
Demo
Test.8989.-.Docs.webm