Skip to content

Allow masking a document #1172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 24, 2025
Merged

Allow masking a document #1172

merged 2 commits into from
Jul 24, 2025

Conversation

sampaccoud
Copy link
Member

@sampaccoud sampaccoud commented Jul 13, 2025

Purpose

Once users have visited a document to which they have access, they can't remove it from their list view anymore.

Several users reported that this is annoying because a document that gets a lot of updates, keeps popping up at the top of their list view. During our latest inter ministerial steering committee, I promised to fix it fast.

They want to be able to mask the document in a click.

Proposal

  • Add a field "is_masked" on the LinkTrace model
  • Add an API action on documents detail endpoint through which logged-in users can mask/unmask a document for themselves
  • Add a filter allowing to see only masked/unmasked documents (by default, masked documents are hidden from list views)
  • Update failing tests and add tests for the new "mask" API action

Once this is merged, we will be able to add a "masked documents" section in the left side bar where the masked documents can still be found. Progressive disclosure design commands that the "masked documents" section is only shown if there is at least one document in it. @rl-83 I've seen your mockups once but could not find them anymore in Docs' Figma. Can you add them here for reference?

@sampaccoud sampaccoud requested a review from lunika July 13, 2025 18:20
@sampaccoud sampaccoud self-assigned this Jul 13, 2025
@sampaccoud sampaccoud added python Pull requests that update Python code feature add a new feature backend labels Jul 13, 2025
@sampaccoud sampaccoud requested a review from AntoLC July 13, 2025 18:34
@sampaccoud sampaccoud changed the title Allow deprioritizing a document Allow masking a document Jul 14, 2025
@sampaccoud sampaccoud force-pushed the allow-deprioritizing-a-document branch from 987641c to 14870b3 Compare July 22, 2025 17:46
@sampaccoud sampaccoud requested review from AntoLC, rvveber and lunika July 22, 2025 17:48
@sampaccoud sampaccoud force-pushed the allow-deprioritizing-a-document branch from 14870b3 to a6de78b Compare July 24, 2025 10:34
@sampaccoud sampaccoud enabled auto-merge (rebase) July 24, 2025 10:34
auto-merge was automatically disabled July 24, 2025 10:48

Base branch requires signed commits

@sampaccoud sampaccoud force-pushed the allow-deprioritizing-a-document branch from a6de78b to bb0d494 Compare July 24, 2025 11:15
@sampaccoud sampaccoud force-pushed the allow-deprioritizing-a-document branch from bb0d494 to 61518d3 Compare July 24, 2025 15:51
This was most likely due to copy pasta fail.
Once users have visited a document to which they have access,
they can't remove it from their list view anymore. Several
users reported that this is annoying because a document that
gets a lot of updates keeps popping up at the top of their list
view.

They want to be able to mask the document in a click. We propose
to add a "masked documents" section in the left side bar where the
masked documents can still be found.
@sampaccoud sampaccoud force-pushed the allow-deprioritizing-a-document branch from 61518d3 to 0b301b9 Compare July 24, 2025 16:40
@sampaccoud sampaccoud enabled auto-merge (rebase) July 24, 2025 16:40
auto-merge was automatically disabled July 24, 2025 16:53

Base branch requires signed commits

@AntoLC AntoLC merged commit 0b301b9 into main Jul 24, 2025
20 of 21 checks passed
@AntoLC AntoLC deleted the allow-deprioritizing-a-document branch July 24, 2025 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature add a new feature python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants