-
Notifications
You must be signed in to change notification settings - Fork 373
Allow masking a document #1172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Allow masking a document #1172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
reviewed
Jul 15, 2025
src/backend/core/tests/documents/test_api_documents_favorite_list.py
Outdated
Show resolved
Hide resolved
lunika
reviewed
Jul 21, 2025
987641c
to
14870b3
Compare
AntoLC
approved these changes
Jul 23, 2025
lunika
approved these changes
Jul 23, 2025
14870b3
to
a6de78b
Compare
auto-merge was automatically disabled
July 24, 2025 10:48
Base branch requires signed commits
a6de78b
to
bb0d494
Compare
rvveber
approved these changes
Jul 24, 2025
bb0d494
to
61518d3
Compare
This was most likely due to copy pasta fail.
Once users have visited a document to which they have access, they can't remove it from their list view anymore. Several users reported that this is annoying because a document that gets a lot of updates keeps popping up at the top of their list view. They want to be able to mask the document in a click. We propose to add a "masked documents" section in the left side bar where the masked documents can still be found.
61518d3
to
0b301b9
Compare
auto-merge was automatically disabled
July 24, 2025 16:53
Base branch requires signed commits
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Once users have visited a document to which they have access, they can't remove it from their list view anymore.
Several users reported that this is annoying because a document that gets a lot of updates, keeps popping up at the top of their list view. During our latest inter ministerial steering committee, I promised to fix it fast.
They want to be able to mask the document in a click.
Proposal
Once this is merged, we will be able to add a "masked documents" section in the left side bar where the masked documents can still be found. Progressive disclosure design commands that the "masked documents" section is only shown if there is at least one document in it. @rl-83 I've seen your mockups once but could not find them anymore in Docs' Figma. Can you add them here for reference?