Skip to content

(frontend) fix callout block navigation issues & styles #1161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

(frontend) fix callout block navigation issues & styles #1161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37cc26a
💄(frontend) update callout styles
ZouicheOmar Jul 23, 2025
ebffb65
🐛(frontend) fix callout block cursor position
ZouicheOmar Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/frontend/apps/impress/src/features/docs/doc-editor/components/BlockNoteEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ export const BlockNoteEditor = ({ doc, provider }: BlockNoteEditorProps) => {
},
uploadFile,
schema: blockNoteSchema,
disableExtensions: ['gapCursor'],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see the bug actually, could you provide a image or a small video of it ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Demo

Screencast.from.2025-07-23.16-33-36.mp4

Here's what it looks like with the extension enabled. When the cursor goes above or between callouts, a GapCursor instance is added.
The extension comes with tiptap, yet it's not used by any of the Docs blocks.

On the blocknotejs docs

Screencast.from.2025-07-10.16-18-52.mp4

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I am scared of the side effects that we do not foresee.
I can see in the doc that it is useful for table as well.
https://prosemirror.net/docs/ref/#gapcursor

@YousefED Do you have a opinion about it ?
Do you think we could remove this extension without too much problems ?

},
[collabName, lang, provider, uploadFile],
);
Expand Down
3 changes: 2 additions & 1 deletion ...ntend/apps/impress/src/features/docs/doc-editor/components/custom-blocks/CalloutBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ export const CalloutBlock = createReactBlockSpec(
}
`}
$align="center"
$justify="center"
$height="28px"
$width="28px"
$radius="4px"
Expand All @@ -85,7 +86,7 @@ export const CalloutBlock = createReactBlockSpec(
onEmojiSelect={onEmojiSelect}
/>
)}
<Box as="p" className="inline-content" ref={contentRef} />
<Box className="inline-content" ref={contentRef} $justify="center" />
</Box>
);
},
Expand Down
Loading