Share document modal #1045
Closed
Share document modal #1045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ovgodd
requested changes
Jul 29, 2025
There was a problem hiding this comment.
Hello! Thanks for the PR 🙌
As described in the issue, there are still a couple of small accessibility details to address:
In DocShareModalFooter, the "add_link" icon used in the "Copy link" button is decorative and should be marked with aria-hidden="true" to prevent screen readers from announcing it.
Similarly, in DocVisibility, the lock icon (e.g. "lock", "public") is purely visual and should also include aria-hidden="true".
Aside from that, everything else looks good to me. Thank
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the share document modal : aria-hidden=true added for icons + aria-label for the icon 'more actions'
Issue : #966