Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated readme.md & Added few keyboard shortcuts #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mebinthattil
Copy link

@mebinthattil mebinthattil commented Mar 25, 2025

The readme lacked few critical links such as :

  • trying sugar online
  • experience sugar page
  • sugar wiki

Also changed the download link to now directly point to the download page of the speak activity. Before it pointed to a page where you would have to search for the speak activity and then download it.


Added few keyboard shortcuts for common actions such as:

  • speaking the text
  • switching to speak mode
  • switching to chatbot mode
  • adjusting pitch
  • cycling through mouth types

@mebinthattil mebinthattil changed the title Updated readme.md Updated readme.md & Added few keyboard shortcuts Mar 25, 2025
@quozl
Copy link
Contributor

quozl commented Mar 25, 2025

Please never close a pull request unnecessarily. You have split away from the other discussion, and it looks like you are trying to hide it. Of course you aren't, but there's no reason to have closed. You could have reset your branch to ec299b7 and pushed it and your other pull request would be updated.

The older pull request #35

Our guidance on branching you have not followed;

Our guidance on commit messages you have not followed;

GitHub correctly abbreviates your ec299b7 commit message when rendering the pull request pages. The ellipsis shows you have not kept to common commit message formatting, which our guidance reinforces.

Please fix the commit messages.

@mebinthattil
Copy link
Author

Going forward I shall make sure to strictly abide by the contribution docs. The contribution docs mention that I need to create a separate branch and create a PR from that to the master branch of the speak repo.

But since this current PR is on the master branch of my fork does that mean that I have to close this PR and create another PR from a separate branch? Is there a way I can change the source branch for a PR?

I apologize for any inconvenience caused and assure you that I will take steps to prevent such mistakes from occurring in the future.

@quozl
Copy link
Contributor

quozl commented Mar 26, 2025

@mebinthattil
Copy link
Author

That article mentions how the base repository can be changed, but in my case I want to change the source repo (which I think cannot be edited).

Changing base repo would mean that I could merge this PR into another fork from the sugar speak repo.

But what I need to do is to merge this PR to the master of speak repo, but from a branch on my fork.

So does this leave me with no other option other than closing this PR? Again sorry for this, will make sure not to make these mistakes again.

@quozl
Copy link
Contributor

quozl commented Mar 28, 2025

Hmm, thanks, let me know what you find.

@mebinthattil
Copy link
Author

I see no other option other than closing this PR and creating another one. May I proceed?

@quozl
Copy link
Contributor

quozl commented Mar 28, 2025

You should learn how to rewrite your commits and then force push, that way only this pull request is updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants