-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated readme.md & Added few keyboard shortcuts #36
base: master
Are you sure you want to change the base?
Conversation
…ext, switching modes etc.
Please never close a pull request unnecessarily. You have split away from the other discussion, and it looks like you are trying to hide it. Of course you aren't, but there's no reason to have closed. You could have reset your branch to ec299b7 and pushed it and your other pull request would be updated. The older pull request #35 Our guidance on branching you have not followed; Our guidance on commit messages you have not followed; GitHub correctly abbreviates your ec299b7 commit message when rendering the pull request pages. The ellipsis shows you have not kept to common commit message formatting, which our guidance reinforces. Please fix the commit messages. |
Going forward I shall make sure to strictly abide by the contribution docs. The contribution docs mention that I need to create a separate branch and create a PR from that to the master branch of the speak repo. But since this current PR is on the master branch of my fork does that mean that I have to close this PR and create another PR from a separate branch? Is there a way I can change the source branch for a PR? I apologize for any inconvenience caused and assure you that I will take steps to prevent such mistakes from occurring in the future. |
I've never had to do it, because I always get it right. 😀 https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/changing-the-base-branch-of-a-pull-request looks interesting. |
That article mentions how the base repository can be changed, but in my case I want to change the source repo (which I think cannot be edited). Changing base repo would mean that I could merge this PR into another fork from the sugar speak repo. But what I need to do is to merge this PR to the master of speak repo, but from a branch on my fork. So does this leave me with no other option other than closing this PR? Again sorry for this, will make sure not to make these mistakes again. |
Hmm, thanks, let me know what you find. |
I see no other option other than closing this PR and creating another one. May I proceed? |
You should learn how to rewrite your commits and then force push, that way only this pull request is updated. |
The readme lacked few critical links such as :
Also changed the download link to now directly point to the download page of the speak activity. Before it pointed to a page where you would have to search for the speak activity and then download it.
Added few keyboard shortcuts for common actions such as: