-
Notifications
You must be signed in to change notification settings - Fork 979
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test:adding test for synthutils.js #4210
test:adding test for synthutils.js #4210
Conversation
hi @walterbender I was working on this for a week I added tests for all functions. Please take a look or If you want to some changes I am happy to work on it |
Hey, the tests look good but there are some issues And i think we are not supposed to change the package.json/lock files |
Since your error is due to missing dependencies in package-lock.json, run:
|
@Shyam-Raghuwanshi It looks like this PR has been inactive for a while. Are you still working on it, or would you mind if I take over? |
The problem had been that somehow the dependencies were not getting set up properly. Once there were installed, it worked fine. |
@walterbender i will fix |
hi @walterbender please try again, I clone the branch separately and fix a dependencies issue and if you are still facing some issue please tell me |
adding test for all the function of synthutils.js
#4124
locally test my tests
npm install tone
jest synthutils.test.js