refractor: utils/munsell.js: linting, prettify #2823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@meganindya Please review this. Thanks. |
|
@abhishekkumar08 when declaring globals could you please also write in the same file where those globals come from?. That would be more helpful I think, otherwise it serves no other purpose than just making the eslint errors go away, defeating the purpose of enabling them in the first place. cc @meganindya |
|
@ksraj123 yeah okay I would surely keep this in mind. Thanks for the suggestion. |
|
@ksraj123 @meganindya Please review this. Are the global locations correct? |
meganindya
force-pushed
the
refractor/munsell.js
branch
from
b3637ad to
0c999e8
Compare
meganindya
approved these changes
Feb 9, 2021
meganindya
force-pushed
the
refractor/munsell.js
branch
from
0c999e8 to
1c14c05
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference #2630, #2609