Update linting rules

sugarlabs · Jan 23, 2021 · c39078f · c39078f
1 parent 18294c3
commit c39078f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 15 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,25 +1,22 @@
 {
-  "parser": "babel-eslint",
   "env": {
     "es6": true,
-    "browser": true,
-    "node": true
+    "browser": true
   },
   "extends": ["eslint:recommended", "prettier"],
   "rules": {
-    // "no-console": "warn",
+    "no-console": "warn",
     "no-mixed-spaces-and-tabs": "warn",
-    // "no-unused-vars": "warn",
-    // "no-use-before-define": "error",
+    "no-unused-vars": "warn",
+    "no-use-before-define": "error",
     "prefer-const": [
       "warn",
       {
         "destructuring": "any",
         "ignoreReadBeforeAssign": true
       }
     ],
-    "no-undef": "warn",
-    "no-unused-vars": "off",
+    "no-undef": "error",
     "indent": ["warn", 4, { "SwitchCase": 1 }],
     "quotes": ["warn", "double", { "avoidEscape": true }],
     "semi": "error",

diff --git a/.github/linters/.eslintrc.yml b/.github/linters/.eslintrc.yml
@@ -1,14 +1,20 @@
 {
-  "parser": "babel-eslint",
-  "env": { "es6": true, "browser": true, "node": true },
+  "env": { "es6": true, "browser": true },
   "extends": ["eslint:recommended"],
   "rules": {
-      # "no-console": "warn",
+      "no-console": "warn",
       "no-mixed-spaces-and-tabs": "warn",
-      # "no-unused-vars": "warn",
-      # "no-use-before-define": "error",
-      "no-undef": "off",
-      "no-unused-vars": "off",
+      "no-unused-vars": "warn",
+      "no-use-before-define": "error",
+      "prefer-const": [
+        "warn",
+        {
+          "destructuring": "any",
+          "ignoreReadBeforeAssign": true
+        }
+      ],
+      "no-undef": "error",
+      "no-unused-vars": "warn",
       "indent": ["warn", 4, { "SwitchCase": 1 }],
       "quotes": ["warn", "double", { "avoidEscape": true }],
       "semi": "error",