Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added dark mode toggle, button design changes, and adjusted layout #64

Merged
merged 3 commits into from
Oct 29, 2024

Conversation

AnsharaFayazBeigh
Copy link
Contributor

@AnsharaFayazBeigh AnsharaFayazBeigh commented Oct 12, 2024

@jinx-vi-0
Issue #26
This pull request introduces a dark mode feature, along with some design and layout enhancements.

  1. Dark Mode Toggle: Implemented a button that allows users to switch between light and dark mode.

  2. Adjusted CSS to ensure the dark mode complements the existing design, with changes to the background and text colors.

  3. Ensure all elements, including the header, links, and text, adapt properly to dark mode.
    Button Styling: Updated the styling of the toggle button to match the overall design:
    The font was updated to match the rest of the website (Poppins).
    Added smooth transition effects for hover states.
    Improved the button’s appearance by adjusting padding, border radius, and colors.
    Layout Adjustments: Tweaked the layout in style.css to enhance user experience.
    Minor changes to spacing and alignment of elements
    Testing: Tested the changes locally, and everything works as expected in both light and dark modes.
    No major visual or functional regressions were encountered.
    After Dark mode implementation :
    image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Boom! Your pull request just flew into the BlogLog HQ. High fives all around! Our team of tech wizards will check it out and get back to you faster than you can say 'code ninja!' Thanks for leveling up the project!

@AnsharaFayazBeigh
Copy link
Contributor Author

Also about the merge conflicts ( i checked my code editor and tried to fetch) :

image how

ever it doesn't show any but the merge conflicts are present in the pull request..

@jinx-vi-0

Copy link
Owner

@sudo-dpkg sudo-dpkg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. If I'm enabling dark mode, it should reflect on all the pages.
  2. Fetch latest changes from the main branch.
  3. Fix merge confict.

Copy link
Contributor Author

@AnsharaFayazBeigh AnsharaFayazBeigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the required file to make the dark mode consistent.
And reviewed the merge conflicts.. as much as I can manually.

@AnsharaFayazBeigh
Copy link
Contributor Author

@jinx-vi-0 I have incorporated the feature to make the changes uniform ( making the dark-mode uniform). There was a typo with the search bar (it was search). Please review it. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants