Skip to content

Conversation

radik878
Copy link

@radik878 radik878 commented Oct 19, 2025

ultra_compressed() is marked as Compressed, but Clone does not preserve “ultra”
In the ultra_compressed() constructor, the config_type field is set to Compressed. The Clone implementation only distinguishes between Default and Compressed; “ultra” is not present there. As a result, cloning an ultra_compressed config silently downgraded it to compressed (log_blowup 3 → 2). This change:

  • Introduces a dedicated UltraCompressed enum variant.
  • Sets config_type to UltraCompressed in ultra_compressed().
  • Extends Clone to return ultra_compressed() when config_type is UltraCompressed.
  • Adds a unit test asserting that cloning an ultra config preserves log_blowup == 3.

This ensures consistent behavior when configs are cloned in utilities or helper flows.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant