Skip to content

fix(sdk): reuse Channel in NetworkClient #2459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(sdk): reuse Channel in NetworkClient #2459

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b5ec557
wip
ctian1 Sep 18, 2025
38ca777
wip
ctian1 Sep 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 22 additions & 17 deletions crates/sdk/src/network/client.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ use reqwest_middleware::ClientWithMiddleware as HttpClientWithMiddleware;
use serde::{de::DeserializeOwned, Serialize};
use sp1_core_machine::io::SP1Stdin;
use sp1_prover::{HashableKey, SP1VerifyingKey};
use tokio::sync::OnceCell;
use tonic::{transport::Channel, Code};

use super::{
Expand Down Expand Up @@ -47,6 +48,7 @@ pub struct NetworkClient {
pub(crate) signer: NetworkSigner,
pub(crate) http: HttpClientWithMiddleware,
pub(crate) rpc_url: String,
pub(crate) channel: OnceCell<Channel>,
}

#[async_trait]
Expand Down Expand Up @@ -85,7 +87,7 @@ impl NetworkClient {
.pool_idle_timeout(Duration::from_secs(240))
.build()
.unwrap();
Self { signer, http: client.into(), rpc_url: rpc_url.into() }
Self { signer, http: client.into(), rpc_url: rpc_url.into(), channel: OnceCell::new() }
}

/// Get the latest nonce for this account's address.
Expand Down Expand Up @@ -475,26 +477,29 @@ impl NetworkClient {
.await
}

pub(crate) async fn get_channel(&self) -> Result<Channel> {
Ok(self
.channel
.get_or_try_init(|| {
self.with_retry(
|| async {
let channel = grpc::configure_endpoint(&self.rpc_url)?.connect().await?;
Ok(channel)
},
"connecting to network rpc",
)
})
.await
.map_err(|e| anyhow::anyhow!("Failed to connect: {:?}", e))?
.clone())
}

pub(crate) async fn prover_network_client(&self) -> Result<ProverNetworkClient<Channel>> {
self.with_retry(
|| async {
let channel = grpc::configure_endpoint(&self.rpc_url)?.connect().await?;
Ok(ProverNetworkClient::new(channel))
},
"creating network client",
)
.await
Ok(ProverNetworkClient::new(self.get_channel().await?))
}

pub(crate) async fn artifact_store_client(&self) -> Result<ArtifactStoreClient<Channel>> {
self.with_retry(
|| async {
let channel = grpc::configure_endpoint(&self.rpc_url)?.connect().await?;
Ok(ArtifactStoreClient::new(channel))
},
"creating artifact client",
)
.await
Ok(ArtifactStoreClient::new(self.get_channel().await?))
}

pub(crate) async fn create_artifact_with_content<T: Serialize + Send + Sync>(
Expand Down
Loading