Skip to content

docker pull inherits stderr and stdout, so docker logs are printed #2339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from
Draft

docker pull inherits stderr and stdout, so docker logs are printed #2339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions crates/cuda/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -216,10 +216,16 @@ impl SP1CudaProver {
}

// Pull the docker image if it's not present
if let Err(e) = Command::new("docker").args(["pull", &image_name]).output() {
return Err(format!("Failed to pull Docker image: {}. Please check your internet connection and Docker permissions.", e).into());
let status = Command::new("docker")
.args(&["pull", &image_name])
.status()
.map_err(|e| format!("Failed to pull Docker image: {}. Please check your internet connection and Docker permissions.", e))?;

if !status.success() {
return Err(format!("`docker pull` exited with: {}", status).into());
}


// Start the docker container
let rust_log_level = std::env::var("RUST_LOG").unwrap_or_else(|_| "none".to_string());
Command::new("docker")
Expand Down
Loading