Skip to content

Investigate GitHub issue 351#359

Open
subsy wants to merge 1 commit intomainfrom
claude/investigate-gh-issue-351-fKSDF
Open

Investigate GitHub issue 351#359
subsy wants to merge 1 commit intomainfrom
claude/investigate-gh-issue-351-fKSDF

Conversation

@subsy
Copy link
Owner

@subsy subsy commented Mar 13, 2026

https://claude.ai/code/session_019ZcFsrBHfdTqZHgHZBhAUq

Summary by CodeRabbit

  • Bug Fixes

    • Added warnings when PRD generation skills are unavailable, informing users of potential quality impacts and providing installation guidance.
  • Refactor

    • Enhanced PRD generation system prompt to improve focus on document creation.

#351)

When the ralph-tui-prd skill fails to load (e.g. ~/.copilot/skills doesn't
exist), the agent falls back to a minimal system prompt that lacks the
"do NOT start implementing" instruction. This causes agents like GitHub
Copilot to skip PRD creation and jump straight to implementation.

Two fixes:
- Add warning when skill loading fails so users know to run setup
- Add "do NOT implement" guardrail to the fallback system prompt

https://claude.ai/code/session_019ZcFsrBHfdTqZHgHZBhAUq
@vercel
Copy link

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
ralph-tui Ignored Ignored Mar 13, 2026 6:12pm

Request Review

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 13, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 186063cb-b266-4edb-86cf-e2382e9483ed

📥 Commits

Reviewing files that changed from the base of the PR and between fcea670 and bc17f8d.

📒 Files selected for processing (2)
  • src/chat/engine.ts
  • src/commands/create-prd.tsx

Walkthrough

Added an instruction to the PRD generation system prompt clarifying that the agent should only create the PRD document without implementing, and introduced warning messages when the PRD skill is not available to alert users of potential quality reductions.

Changes

Cohort / File(s) Summary
PRD System Prompt
src/chat/engine.ts
Added instruction line to clarify the agent's role is exclusively PRD document creation, not implementation.
PRD Skill Warnings
src/commands/create-prd.tsx
Introduced two warning messages in chat mode when bundled PRD skill is unavailable, informing users of potential quality impacts and installation/configuration steps.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 1 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Title check ❓ Inconclusive The title 'Investigate GitHub issue 351' is vague and generic, using non-descriptive language that doesn't convey the actual changes made (adding guardrails and warnings for PRD generation). Consider a more descriptive title that reflects the main change, such as 'Add PRD generation guardrails and skill-loading warnings' or 'Fix PRD fallback behaviour with missing skills'.
✅ Passed checks (1 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/investigate-gh-issue-351-fKSDF
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link

codecov bot commented Mar 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 47.35%. Comparing base (070344f) to head (bc17f8d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   47.89%   47.35%   -0.55%     
==========================================
  Files         105      111       +6     
  Lines       34358    36446    +2088     
==========================================
+ Hits        16457    17258     +801     
- Misses      17901    19188    +1287     
Files with missing lines Coverage Δ
src/chat/engine.ts 63.54% <ø> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants