-
Notifications
You must be signed in to change notification settings - Fork 1
Add sorobanTxs field to transaction information and expose unsafeApi parameter #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Coverage reportCaution Test run failed
Test suite run failedFailed tests: 1/72. Failed suites: 1/8.
Report generated by 🧪jest coverage report action from 55c651c |
@@ -52,6 +53,10 @@ export class StellarApiService extends ApiService< | |||
): Promise<StellarApiService> { | |||
let network: StellarProjectNetworkConfig; | |||
|
|||
const needSorobanTxMeta = !!project.dataSources.find( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs to take into account project upgrades and dynamic datasoruces.
Does the user requesting this feature also need to access the transactions from soroban events?
/** | ||
* Need soroban meta data | ||
*/ | ||
sorobanTxMeta?: boolean; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this should be determined based on the project datasources not on a user setting
Description
Add sorobanTxs field to transaction information and expose unsafeApi parameter
Fixes # (issue)
Type of change
Please delete options that are not relevant.
Checklist