Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: toast #447

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: toast #447

merged 2 commits into from
Jul 9, 2024

Conversation

Sid-80
Copy link
Contributor

@Sid-80 Sid-80 commented Jul 9, 2024

Related Issue

resolves #444

Description

Added the toast for invalid credentials and resolves the bug present in logout functionality

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Recording.2024-07-09.135259.mp4

Checklist:

  • I have performed a self-review of my code
  • I have read and followed the Contribution Guidelines.
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 9, 2024

@Sid-80 is attempting to deploy a commit to the subhadeep3902's projects Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Jul 9, 2024

Welcome to Blox AI! 🎉 Thank you for submitting your pull request. We're excited to review it! 🚀 If you haven't already, be sure to check out our site to learn more about how Blox AI makes crafting flowcharts and diagrams a breeze, and how you can get explanations from the top Google Gemini model about your creations. Start visualizing your ideas today! Visit Blox AI for more information.

Copy link

vercel bot commented Jul 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blox-ai ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:06pm

@subhadeeproy3902
Copy link
Owner

image

@Sid-80
Also do one thing:

  1. Make the toast in dark mode for the dark mode -> such that when Error comes its bg will of error i.e red
  2. Make the toast equally feasible to the light and dark toggling !
  3. If success then bg should be green

@Sid-80
Copy link
Contributor Author

Sid-80 commented Jul 9, 2024

@subhadeeproy3902 There is no need if successful. It will be redirected to the dashboard

@Sid-80
Copy link
Contributor Author

Sid-80 commented Jul 9, 2024

Recording.2024-07-09.210127.mp4

@subhadeeproy3902 subhadeeproy3902 merged commit e586c8d into subhadeeproy3902:main Jul 9, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat: Toast for invalid email and password
2 participants