-
Notifications
You must be signed in to change notification settings - Fork 38
feat: Initial example of C integration #242
Conversation
4de517c
to
b1dc317
Compare
Now working. Some areas of improvements could be tying it into the larger build system:
Initial reactions to working with the raw FFI:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love that we can add C to our retinue of supported languages. Some general feedback:
Can we put the example in a sub-folder? e.g., $ROOT/c/example/main.c
And, can we add a README.md at $ROOT/c/README.md
? It doesn't have to be very long, but otherwise model it roughly after the other READMEs in our language folders.
Super cool :D
Oh, also: please file an issue to get a test workflow in place for CI. It would be nice to be made aware of conspicuous support regressions. |
bc31cd7
to
11a26c5
Compare
|
* Add base example and build script in C * Transform generated C headers from safer_ffi with idiomatic type names.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The transformer is very interesting 😳 we'll have to keep an eye on it to make sure we don't end up with any funky transformations.
Need to figure out some text encoding stuff and clean ups, but this C snippet links and runs against libnoosphere