Repository navigation
Fix telemetry throwing when the default locale is invalid - #157
Open
AlexPayment wants to merge 1 commit into
Open
AlexPayment wants to merge 1 commit into
AlexPayment wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: cf98d22 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@AlexPayment is attempting to deploy a commit to the Stytch Auth Team on Vercel. A member of the Team first needs to authorize it. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NetworkClient.createTelemetryBlob()reads the time zone withIntl.DateTimeFormat().resolvedOptions().timeZone. Browsers with an invalid default locale throw RangeError: Internal error. Icu error. on that call. We saw it on browsers withnavigator.languageset tounited states-UNITED STATES.createTelemetryBlob()runs in theStytchClientconstructor (thesdk_instance_instantiatedevent). In the Next.js setup, where the client is created at module scope, the whole page crashes.This PR wraps the lookup in a
getTimezone()helper. If the call without a locale throws, it retries with'en-US'. The time zone doesn't depend on the locale, so the reported value doesn't change. If that fails too, it returns an empty string, so telemetry can never break the SDK.Includes a patch changeset for
@stytch/nextjs,@stytch/reactand@stytch/vanilla-js.Test plan