Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Support basic keyword search for OPDS v1.2 #558

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

aaronleopold
Copy link
Collaborator

Resolves #552

The linked issue is marked as a bug, but really this just wasn't implemented 😛 I'll leave as a draft until I resolve a quirk with Panels, I wrote a note for it in the code. For those following and interested, I posted about it in the Panels discord.

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 191 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
core/src/opds/v1_2/feed.rs 0.00% 87 Missing ⚠️
apps/server/src/routers/opds/v1_2.rs 0.00% 83 Missing ⚠️
core/src/opds/v1_2/opensearch.rs 0.00% 18 Missing ⚠️
core/src/db/query/pagination.rs 0.00% 3 Missing ⚠️
Files with missing lines Coverage Δ
core/src/db/query/pagination.rs 0.00% <0.00%> (ø)
core/src/opds/v1_2/opensearch.rs 0.00% <0.00%> (ø)
apps/server/src/routers/opds/v1_2.rs 0.00% <0.00%> (ø)
core/src/opds/v1_2/feed.rs 34.66% <0.00%> (+0.80%) ⬆️

... and 5 files with indirect coverage changes

@aaronleopold aaronleopold marked this pull request as ready for review January 10, 2025 19:07
@aaronleopold
Copy link
Collaborator Author

aaronleopold commented Jan 10, 2025

After discussions, it appears this is not necessarily an issue with Stump. I'll merge this as-is, with tentative future changes depending on whether pagination for search results in Panels requires it

@aaronleopold aaronleopold merged commit f32244d into experimental Jan 10, 2025
9 checks passed
@aaronleopold aaronleopold deleted the opds-1.2-search-support branch January 10, 2025 19:08
@tmenguy
Copy link

tmenguy commented Jan 13, 2025

great! thx a lot, what is teh panel issue?

@tmenguy
Copy link

tmenguy commented Jan 13, 2025

(will look into their discord too)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants