feat: move to ESLint v9 👏 #250
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: Projects must now use ESLint v9 in order to use these rulesets.
robertrossmann
requested review from
matejpolak and
developer239
as code owners
robertrossmann
added
enhancement
- @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected]
- @strv/[email protected]
- @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected] - @strv/[email protected]
Used when working with vitest.
jirikapoun
reviewed
Feb 19, 2025
There was a problem hiding this comment.
I have added one small suggestion, otherwise it looks good.
I have tried out the new version in the Surge codebase and only a few adjustments were necessary:
- Rename
@typescript-eslint/indentrule config to@stylistic/indent - Rename
@typescript-eslint/no-throw-literalrule config to@typescript-eslint/only-throw-error - Add ignore for
fetchandFormDatatonode/no-unsupported-features/node-builtinsrule config (or potentially even better, upgrade to Node 22)
I also had to regenerate package-lock.json in order to resolve all peer deps conflicts and completely drop one very old ESLint plugin (eslint-plugin-filenames) – I think it would be possible to salvage it by patching it, but we don't really need it so I didn't bother.
| @@ -2,7 +2,7 @@ import node from './packages/eslint-config-node/index.mjs' | |||
| import optional from './packages/eslint-config-node/optional.mjs' | |||
| import style from './packages/eslint-config-node/style.mjs' | |||
|
|
|||
| /** @type {Array<import("eslint").Linter.FlatConfig>} */ | |||
| /** @type {Array<import("eslint").Linter.Config>} */ | |||
| const configs = [{ | |||
| linterOptions: { | |||
| reportUnusedDisableDirectives: true, | |||
There was a problem hiding this comment.
Suggested change
| reportUnusedDisableDirectives: true, | |
| reportUnusedDisableDirectives: true, | |
| }, | |
| settings: { | |
| 'import/resolver': { typescript: {} }, |
If this setting gets added here...
Comment on lines
19
to
20
| // TODO: Figure out why ESLint cannot resolve the @typescript-eslint packages | ||
| 'import/no-unresolved': 'off', |
There was a problem hiding this comment.
...we can get rid of this override.
Suggested change
| // TODO: Figure out why ESLint cannot resolve the @typescript-eslint packages | |
| 'import/no-unresolved': 'off', |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Projects must now use ESLint v9 in order to use these rulesets.