Skip to content

fix: show unfixable rubocop offenses on format failure #1897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jar-stripe wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: show unfixable rubocop offenses on format failure #1897

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ alias lint-check := format-check
# ⭐ check style & formatting for all files, fixing what we can
lint: (format-check "--autocorrect")

# NOTE: "-o /dev/null" is vital - rubocop has super noisy output and codegen will crash when formatting ruby if everything gets printed
# so, we send all its output to the void
# copy of `lint` with less output
format: (format-check "-o /dev/null --autocorrect")
# Quiet version of `lint` for use by codegen and CI.
# --display-only-fail-level-offenses suppresses the ~1.5MB report of corrected
# offenses and only shows uncorrectable ones.
format: (format-check "--autocorrect --display-only-fail-level-offenses")
Comment thread
jar-stripe marked this conversation as resolved.

update-certs: install
bundle exec rake update_certs
Expand Down
Loading